fix: implement lazy evaluation in Coalesce function #2270
Merged
+56
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andygrove , Please kick off the CI whenever you get a chance |
coderfender
force-pushed
the
lazy_eval_coalesce_case_fallback_statement
branch
from
cd2c3cb to
f0055e3
Compare
|
Rebased with main branch . |
coderfender
force-pushed
the
lazy_eval_coalesce_case_fallback_statement
branch
from
f0055e3 to
e0cdb86
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2270 +/- ##
============================================
+ Coverage 56.12% 57.91% +1.78%
- Complexity 976 1290 +314
============================================
Files 119 146 +27
Lines 11743 13367 +1624
Branches 2251 2373 +122
============================================
+ Hits 6591 7741 +1150
- Misses 4012 4369 +357
- Partials 1140 1257 +117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@andygrove please take a look whenever you get a chance . |
andygrove
reviewed
Sep 3, 2025
There was a problem hiding this comment.
Thanks @coderfender. This is looking good. I will review tomorrow.
|
Thank you very much @andygrove |
andygrove
reviewed
Sep 3, 2025
andygrove
reviewed
Sep 3, 2025
andygrove
reviewed
Sep 3, 2025
andygrove
reviewed
Sep 3, 2025
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
Outdated
Show resolved
Hide resolved
coderfender
force-pushed
the
lazy_eval_coalesce_case_fallback_statement
branch
from
10f6557 to
206432a
Compare
|
Thank you for merging the PR @andygrove . I will rebase ANSI arithmetic changes PR with main branch and update there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2233
Rationale for this change
Spark performs lazy evaluation with the coalesce function while comet/ data fusion does not . This causes different behavior when one of the expressions errors out (ex: division by zero) .
What changes are included in this PR?
This change essentially converts spark's coalesce nodes into case statement node (to leverage current comet functionality) . This change is minimal and easy to revert once the upstream datafusion bug is fixed.
How are these changes tested?
Unit tests to ensure lazy evaluation is performed